Remove unused and no-longer-needed function compilerCheck#1395
Merged
eddelbuettel merged 2 commits intomasterfrom Jul 21, 2025
Merged
Remove unused and no-longer-needed function compilerCheck#1395eddelbuettel merged 2 commits intomasterfrom
eddelbuettel merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused compilerCheck function and its documentation from the Rcpp package. The function was originally created in 2016 to check for minimal g++ compiler versions but is no longer needed due to improved compiler support and lack of usage across CRAN packages.
- Removes the
compilerCheckfunction from R/compilerCheck.R - Removes corresponding documentation from man/compilerCheck.Rd
- Updates package version from 1.1.0.1 to 1.1.0.2 with appropriate changelog entries
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/compilerCheck.R | Complete removal of the unused compilerCheck function |
| man/compilerCheck.Rd | Removal of corresponding documentation file |
| DESCRIPTION | Version bump to 1.1.0.2 and date update |
| inst/include/Rcpp/config.h | Updates development version strings to match new version |
| ChangeLog | Documents the removal with appropriate changelog entries |
Enchufa2
approved these changes
Jul 20, 2025
Member
Enchufa2
left a comment
Enchufa2
left a comment
There was a problem hiding this comment.
Wasn't exported, so shouldn't break anything.
Member
Author
|
Correct. Next up are the exported and long-deprecated RcppLdPath() and friends and because they were exported I am fearing breakage. We shall see ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the previous PR I noticed this unused function from 2016 hanging around. A search under organization
cranreveals no package using it, and we are generally in a better situation with respect to what the compilers provide / what we need. So while I am generally very careful about removals, this one should be easy.Checklist
R CMD checkstill passes all tests